bootstrap: include event_target into the built-in snapshot

Since the module has to be loaded during bootstrap anyway. PR-URL: #45849 Backport-PR-URL: #46425 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
nodejs · Nov 10, 2023 · 5f37dec · 5f37dec
1 parent c3f56a3
commit 5f37dec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/internal/bootstrap/browser.js b/lib/internal/bootstrap/browser.js
@@ -42,9 +42,11 @@ defineOperation(globalThis, 'setTimeout', timers.setTimeout);
 exposeLazyInterfaces(globalThis, 'internal/abort_controller', [
   'AbortController', 'AbortSignal',
 ]);
-exposeLazyInterfaces(globalThis, 'internal/event_target', [
-  'EventTarget', 'Event',
-]);
+const {
+  EventTarget, Event,
+} = require('internal/event_target');
+exposeInterface(globalThis, 'Event', Event);
+exposeInterface(globalThis, 'EventTarget', EventTarget);
 exposeLazyInterfaces(globalThis, 'internal/worker/io', [
   'MessageChannel', 'MessagePort', 'MessageEvent',
 ]);

diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js
@@ -46,6 +46,7 @@ const expectedModules = new Set([
   'NativeModule internal/constants',
   'NativeModule internal/dns/utils',
   'NativeModule internal/errors',
+  'NativeModule internal/event_target',
   'NativeModule internal/fixed_queue',
   'NativeModule internal/fs/utils',
   'NativeModule internal/idna',
@@ -90,6 +91,7 @@ const expectedModules = new Set([
   'NativeModule internal/vm',
   'NativeModule internal/vm/module',
   'NativeModule internal/wasm_web_api',
+  'NativeModule internal/webidl',
   'NativeModule internal/worker/js_transferable',
   'Internal Binding blob',
   'NativeModule async_hooks',
@@ -99,6 +101,7 @@ const expectedModules = new Set([
   'NativeModule url',
   'NativeModule internal/v8/startup_snapshot',
   'NativeModule vm',
+  'NativeModule util',
 ]);
 
 if (!common.isMainThread) {