util: set super_ property to non-enumerable

Using `util.inherits()` adds a `super_` property to the constructor and inspecting that constructor is going to show that property even though it's not useful for the user. Therefore the property is now set as non-enumerable and such entries are not visible by default when using `console.log()` or `util.inspect()`. PR-URL: #23107 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Oct 1, 2018 · 5e6940d · 5e6940d
1 parent 6df2c55
commit 5e6940d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -285,7 +285,11 @@ function inherits(ctor, superCtor) {
     throw new ERR_INVALID_ARG_TYPE('superCtor.prototype',
                                    'Function', superCtor.prototype);
   }
-  ctor.super_ = superCtor;
+  Object.defineProperty(ctor, 'super_', {
+    value: superCtor,
+    writable: true,
+    configurable: true
+  });
   Object.setPrototypeOf(ctor.prototype, superCtor.prototype);
 }
 

diff --git a/test/parallel/test-util-inherits.js b/test/parallel/test-util-inherits.js
@@ -18,7 +18,15 @@ function B(value) {
 inherits(B, A);
 B.prototype.b = function() { return this._b; };
 
-assert.strictEqual(B.super_, A);
+assert.deepStrictEqual(
+  Object.getOwnPropertyDescriptor(B, 'super_'),
+  {
+    value: A,
+    enumerable: false,
+    configurable: true,
+    writable: true
+  }
+);
 
 const b = new B('b');
 assert.strictEqual(b.a(), 'a');