From 59eeb3b5b99f9adfad47160f29554900ef57d0a5 Mon Sep 17 00:00:00 2001 From: Clemens Backes Date: Mon, 2 Dec 2019 11:37:33 +0100 Subject: [PATCH] src: stop overriding deprecated V8 methods MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These methods will be removed in V8 8.1, hence we need to stop overriding them. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: Michaƫl Zasso Reviewed-By: Jiawen Geng Reviewed-By: Ruben Bridgewater --- src/node_platform.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/node_platform.h b/src/node_platform.h index 79aad88b881f6b..c217480ed1cbb4 100644 --- a/src/node_platform.h +++ b/src/node_platform.h @@ -149,14 +149,6 @@ class NodePlatform : public MultiIsolatePlatform { void CallOnWorkerThread(std::unique_ptr task) override; void CallDelayedOnWorkerThread(std::unique_ptr task, double delay_in_seconds) override; - void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override { - UNREACHABLE(); - } - void CallDelayedOnForegroundThread(v8::Isolate* isolate, - v8::Task* task, - double delay_in_seconds) override { - UNREACHABLE(); - } bool IdleTasksEnabled(v8::Isolate* isolate) override; double MonotonicallyIncreasingTime() override; double CurrentClockTimeMillis() override;