module: fix unintended mutation

Refs: #46061 (comment) PR-URL: #46108 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
nodejs · Jan 20, 2023 · 54896ab · 54896ab
1 parent 1146f02
commit 54896ab
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -29,6 +29,7 @@ const {
   ArrayPrototypeJoin,
   ArrayPrototypeMap,
   ArrayPrototypePush,
+  ArrayPrototypePushApply,
   ArrayPrototypeSlice,
   ArrayPrototypeSplice,
   ArrayPrototypeUnshift,
@@ -667,12 +668,11 @@ Module._findPath = function(request, paths, isMain) {
       return filename;
     }
 
-    if (exts === undefined) {
-      exts = [''];
-    } else {
-      ArrayPrototypeUnshift(exts, '');
+    const extensions = [''];
+    if (exts !== undefined) {
+      ArrayPrototypePushApply(extensions, exts);
     }
-    reportModuleNotFoundToWatchMode(basePath, exts);
+    reportModuleNotFoundToWatchMode(basePath, extensions);
   }
 
   return false;

diff --git a/test/fixtures/require-resolve.js b/test/fixtures/require-resolve.js
@@ -98,3 +98,8 @@ assert.strictEqual(
   require.resolve('./printA.js', {}),
   require.resolve('./printA.js')
 );
+
+assert.strictEqual(
+  require.resolve('no_index/'),
+  path.join(__dirname, 'node_modules', 'no_index', 'lib', 'index.js'),
+)