fs: move method definition from header

We are defining the definition of function in the header file itself. It should be defined in the source file instead of the header file. PR-URL: #36256 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Dec 7, 2020 · 537e5cb · 537e5cb
1 parent 6bc007f
commit 537e5cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/node_file.cc b/src/node_file.cc
@@ -2534,6 +2534,9 @@ void Initialize(Local<Object> target,
               use_promises_symbol).Check();
 }
 
+BindingData* FSReqBase::binding_data() {
+  return binding_data_.get();
+}
 }  // namespace fs
 
 }  // end namespace node

diff --git a/src/node_file.h b/src/node_file.h
@@ -109,7 +109,7 @@ class FSReqBase : public ReqWrap<uv_fs_t> {
 
   void MemoryInfo(MemoryTracker* tracker) const override;
 
-  BindingData* binding_data() { return binding_data_.get(); }
+  BindingData* binding_data();
 
  private:
   std::unique_ptr<FSContinuationData> continuation_data_;