net: don't throw on immediately destroyed socket

Fixes regression introduced in af249fa. With connect being deferred to the next tick, Socket.destroy could be called before connect. Socket.destroy sets _connecting to false which would cause an assertion error. Fixes: #2250 PR-URL: #2251 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
nodejs · Jul 27, 2015 · 503b089 · 503b089
1 parent 2ca5a3d
commit 503b089
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/net.js b/lib/net.js
@@ -927,7 +927,8 @@ function lookupAndConnect(self, options) {
   var addressType = exports.isIP(host);
   if (addressType) {
     process.nextTick(function() {
-      connect(self, host, port, addressType, localAddress, localPort);
+      if (self._connecting)
+        connect(self, host, port, addressType, localAddress, localPort);
     });
     return;
   }

diff --git a/test/parallel/test-net-connect-immediate-destroy.js b/test/parallel/test-net-connect-immediate-destroy.js
@@ -0,0 +1,8 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
+
+const socket = net.connect(common.PORT, common.localhostIPv4, assert.fail);
+socket.on('error', assert.fail);
+socket.destroy();