From 4a16f9b05428fed434aeffda5dafb46cf34cbada Mon Sep 17 00:00:00 2001
From: Adrian Estrada <edsadr@gmail.com>
Date: Tue, 27 Dec 2016 21:43:44 -0500
Subject: [PATCH] test: improve test-fs-empty-readStream.js
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* use const instead of var
* use common.mustCall to control functions execution
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
---
 test/parallel/test-fs-empty-readStream.js | 32 +++++++++++------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/test/parallel/test-fs-empty-readStream.js b/test/parallel/test-fs-empty-readStream.js
index c5a016f9ea2c36..858d07e4f0b982 100644
--- a/test/parallel/test-fs-empty-readStream.js
+++ b/test/parallel/test-fs-empty-readStream.js
@@ -1,30 +1,30 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var path = require('path');
-var fs = require('fs');
+const common = require('../common');
+const assert = require('assert');
+const path = require('path');
+const fs = require('fs');
 
-var emptyFile = path.join(common.fixturesDir, 'empty.txt');
+const emptyFile = path.join(common.fixturesDir, 'empty.txt');
 
-fs.open(emptyFile, 'r', function(error, fd) {
+fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
   assert.ifError(error);
 
-  var read = fs.createReadStream(emptyFile, { 'fd': fd });
+  const read = fs.createReadStream(emptyFile, { 'fd': fd });
 
-  read.once('data', function() {
+  read.once('data', () => {
     throw new Error('data event should not emit');
   });
 
   read.once('end', common.mustCall(function endEvent1() {}));
-});
+}));
 
-fs.open(emptyFile, 'r', function(error, fd) {
+fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
   assert.ifError(error);
 
-  var read = fs.createReadStream(emptyFile, { 'fd': fd });
+  const read = fs.createReadStream(emptyFile, { 'fd': fd });
   read.pause();
 
-  read.once('data', function() {
+  read.once('data', () => {
     throw new Error('data event should not emit');
   });
 
@@ -32,7 +32,7 @@ fs.open(emptyFile, 'r', function(error, fd) {
     throw new Error('end event should not emit');
   });
 
-  setTimeout(function() {
-    assert.equal(read.isPaused(), true);
-  }, common.platformTimeout(50));
-});
+  setTimeout(common.mustCall(() => {
+    assert.strictEqual(read.isPaused(), true);
+  }), common.platformTimeout(50));
+}));