fixup: pjson.name is optional

nodejs · Oct 6, 2024 · 3e1cda8 · 3e1cda8
1 parent bf5265d
commit 3e1cda8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/doc/api/module.md b/doc/api/module.md
@@ -229,7 +229,7 @@ added: REPLACEME
 * `everything` {boolean} Whether to return the full contents of the found package.json
 * Returns: {Object | undefined}
   * data: {Object}
-    * name: {string}
+    * name: {string | undefined}
     * type: {string | undefined}
     * exports: string | string\[] | Record\<string, unknown> | undefined
     * imports: string | string\[] | Record\<string, unknown> | undefined

diff --git a/lib/internal/modules/package_json_reader.js b/lib/internal/modules/package_json_reader.js
@@ -52,7 +52,7 @@ function deserializePackageJSON(path, contents) {
   return {
     data: {
       __proto__: null,
-      name,
+      ...(name !== null && { name }),
       ...(main != null && { main }),
       ...(type != null && { type }),
       ...(plainImports != null && {

diff --git a/typings/internalBinding/modules.d.ts b/typings/internalBinding/modules.d.ts
@@ -1,6 +1,6 @@
 export type PackageType = 'commonjs' | 'module' | 'none'
 export type RecognizedPackageConfig = {
-  name: string
+  name?: string
   main?: any
   type: PackageType
   exports?: string | string[] | Record<string, unknown>