From 379bf1aa8ee602a38209b525cb6a25a804ee334e Mon Sep 17 00:00:00 2001 From: cjihrig Date: Sun, 7 Oct 2018 23:27:08 -0400 Subject: [PATCH] test: update postmortem metadata test for V8 7.1 The V8 7.1 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_class_JSArrayBuffer__byte_length__Object Use: v8dbg_class_JSArrayBuffer__byte_length__size_t - v8dbg_class_JSArrayBufferView__raw_byte_length__Object Use: v8dbg_class_JSArrayBufferView__byte_length__size_t - v8dbg_class_JSArrayBufferView__raw_byte_offset__Object Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t - v8dbg_class_String__length__SMI Use: v8dbg_class_String__length__int32_t Refs: https://github.com/v8/v8/commit/5cfe1a6b121ad004ec3d73b137f84f558aac0efd Refs: https://github.com/v8/v8/commit/c7a0049e1b70e8f455229c8a470df605ea064f70 PR-URL: https://github.com/nodejs/node/pull/23423 Reviewed-By: Colin Ihrig Reviewed-By: Gus Caplan Reviewed-By: Myles Borins --- test/v8-updates/test-postmortem-metadata.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index a67e218c03e8af..bbe74c7d6fd0a1 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -69,10 +69,10 @@ function getExpectedSymbols() { 'v8dbg_class_HeapObject__map__Map', 'v8dbg_class_JSArray__length__Object', 'v8dbg_class_JSArrayBuffer__backing_store__Object', - 'v8dbg_class_JSArrayBuffer__byte_length__Object', + 'v8dbg_class_JSArrayBuffer__byte_length__size_t', 'v8dbg_class_JSArrayBufferView__buffer__Object', - 'v8dbg_class_JSArrayBufferView__raw_byte_length__Object', - 'v8dbg_class_JSArrayBufferView__raw_byte_offset__Object', + 'v8dbg_class_JSArrayBufferView__byte_length__size_t', + 'v8dbg_class_JSArrayBufferView__byte_offset__size_t', 'v8dbg_class_JSDate__value__Object', 'v8dbg_class_JSFunction__context__Context', 'v8dbg_class_JSFunction__shared__SharedFunctionInfo', @@ -103,7 +103,7 @@ function getExpectedSymbols() { 'v8dbg_class_UncompiledData__start_position__int32_t', 'v8dbg_class_SlicedString__offset__SMI', 'v8dbg_class_SlicedString__parent__String', - 'v8dbg_class_String__length__SMI', + 'v8dbg_class_String__length__int32_t', 'v8dbg_class_ThinString__actual__String', 'v8dbg_context_idx_scope_info', 'v8dbg_context_idx_prev',