From 36a026bf440f235dde3f8b56bac51a6c6240ca40 Mon Sep 17 00:00:00 2001 From: Keyhan Vakil Date: Wed, 15 Mar 2023 23:55:19 -0700 Subject: [PATCH] src: remove dead comments about return_code_cache This behavior of sometimes returning the function & other times returning the code cache was removed a long time ago in the referenced PR, as evinced by the return type `MaybeLocal`. Remove these incorrect comments. Refs: https://github.com/nodejs/node/pull/24950 PR-URL: https://github.com/nodejs/node/pull/47083 Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Franziska Hinkelmann Reviewed-By: Chengzhong Wu --- src/node_builtins.cc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/node_builtins.cc b/src/node_builtins.cc index e9bf8a5a0e0b7e..23e1be6536dfc8 100644 --- a/src/node_builtins.cc +++ b/src/node_builtins.cc @@ -256,9 +256,6 @@ bool BuiltinLoader::Add(const char* id, std::string_view utf8source) { return Add(id, UnionBytes(out)); } -// Returns Local of the compiled module if return_code_cache -// is false (we are only compiling the function). -// Otherwise return a Local containing the cache. MaybeLocal BuiltinLoader::LookupAndCompileInternal( Local context, const char* id, @@ -356,9 +353,6 @@ MaybeLocal BuiltinLoader::LookupAndCompileInternal( return scope.Escape(fun); } -// Returns Local of the compiled module if return_code_cache -// is false (we are only compiling the function). -// Otherwise return a Local containing the cache. MaybeLocal BuiltinLoader::LookupAndCompile(Local context, const char* id, Realm* optional_realm) {