events: remove unnecessary checks

This commit removes two truthy checks for object properties that are immediately followed by a strict equality check. The other item in the comparison is guaranteed to be a function by this point in the code, so the truthy check is redundant. PR-URL: #9330 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Nov 3, 2016 · 3550419 · 3550419
1 parent 31690a6
commit 3550419
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -327,7 +327,7 @@ EventEmitter.prototype.removeListener =
       if (!list)
         return this;
 
-      if (list === listener || (list.listener && list.listener === listener)) {
+      if (list === listener || list.listener === listener) {
         if (--this._eventsCount === 0)
           this._events = new EventHandlers();
         else {
@@ -339,8 +339,7 @@ EventEmitter.prototype.removeListener =
         position = -1;
 
         for (i = list.length; i-- > 0;) {
-          if (list[i] === listener ||
-              (list[i].listener && list[i].listener === listener)) {
+          if (list[i] === listener || list[i].listener === listener) {
             originalListener = list[i].listener;
             position = i;
             break;