test_runner: use paths for test locations

This commit transforms test locations to paths when V8 provides file URLs (which seems to be for ESM files). Fixes: #51610 PR-URL: #52010 Fixes: #51392 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
nodejs · Mar 11, 2024 · 328642b · 328642b
1 parent 6d625fe
commit 328642b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -14,6 +14,7 @@ const {
   PromisePrototypeThen,
   PromiseResolve,
   SafePromisePrototypeFinally,
+  StringPrototypeStartsWith,
   StringPrototypeTrim,
   ReflectApply,
   RegExpPrototypeExec,
@@ -58,6 +59,7 @@ const {
 } = require('internal/validators');
 const { setTimeout } = require('timers');
 const { TIMEOUT_MAX } = require('internal/timers');
+const { fileURLToPath } = require('internal/url');
 const { availableParallelism } = require('os');
 const { bigint: hrtime } = process.hrtime;
 const kCallbackAndPromisePresent = 'callbackAndPromisePresent';
@@ -383,6 +385,10 @@ class Test extends AsyncResource {
           this.loc.file = entry.originalSource;
         }
       }
+
+      if (StringPrototypeStartsWith(this.loc.file, 'file://')) {
+        this.loc.file = fileURLToPath(this.loc.file);
+      }
     }
   }
 

diff --git a/test/fixtures/test-runner/output/source_mapped_locations.snapshot b/test/fixtures/test-runner/output/source_mapped_locations.snapshot
@@ -3,7 +3,7 @@ TAP version 13
 not ok 1 - fails
   ---
   duration_ms: *
-  location: 'file:///test/fixtures/test-runner/output/source_mapped_locations.ts:5:1'
+  location: '/test/fixtures/test-runner/output/source_mapped_locations.ts:5:1'
   failureType: 'testCodeFailure'
   error: |-
     Expected values to be strictly equal: