cluster: improve for-loop

PR-URL: #26336 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 12, 2019 · 2a3cca7 · 2a3cca7
1 parent 8b0164a
commit 2a3cca7
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/lib/internal/cluster/master.js b/lib/internal/cluster/master.js
@@ -80,10 +80,7 @@ cluster.setupMaster = function(options) {
     if (message.cmd !== 'NODE_DEBUG_ENABLED')
       return;
 
-    var key;
-    for (key in cluster.workers) {
-      const worker = cluster.workers[key];
-
+    for (const worker of Object.values(cluster.workers)) {
       if (worker.state === 'online' || worker.state === 'listening') {
         process._debugProcess(worker.process.pid);
       } else {
@@ -227,11 +224,10 @@ cluster.disconnect = function(cb) {
   if (workers.length === 0) {
     process.nextTick(() => intercom.emit('disconnect'));
   } else {
-    for (var key in workers) {
-      key = workers[key];
-
-      if (cluster.workers[key].isConnected())
-        cluster.workers[key].disconnect();
+    for (const worker of Object.values(cluster.workers)) {
+      if (worker.isConnected()) {
+        worker.disconnect();
+      }
     }
   }