url: validate URL constructor arg length

PR-URL: #47513 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Filip Skokan <[email protected]>
nodejs · Nov 10, 2023 · 227e749 · 227e749
1 parent bf4ee17
commit 227e749
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 12 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -623,6 +623,10 @@ function isURL(self) {
 
 class URL {
   constructor(input, base = undefined) {
+    if (arguments.length === 0) {
+      throw new ERR_MISSING_ARGS('url');
+    }
+
     // toUSVString is not needed.
     input = `${input}`;
     this[context] = new URLContext();

diff --git a/test/parallel/test-url-canParse-whatwg.js b/test/parallel/test-url-canParse-whatwg.js
@@ -1,12 +1,12 @@
-'use strict';
-
-require('../common');
-const assert = require('assert');
-
-// One argument is required
-assert.throws(() => {
-  URL.canParse();
-}, {
-  code: 'ERR_MISSING_ARGS',
-  name: 'TypeError'
-});
+'use strict';
+
+require('../common');
+const assert = require('assert');
+
+// One argument is required
+assert.throws(() => {
+  URL.canParse();
+}, {
+  code: 'ERR_MISSING_ARGS',
+  name: 'TypeError',
+});
diff --git a/test/parallel/test-whatwg-url-custom-parsing.js b/test/parallel/test-whatwg-url-custom-parsing.js
@@ -78,3 +78,10 @@ for (const test of additional_tests) {
   if (test.search) assert.strictEqual(url.search, test.search);
   if (test.hash) assert.strictEqual(url.hash, test.hash);
 }
+
+assert.throws(() => {
+  new URL();
+}, {
+  name: 'TypeError',
+  code: 'ERR_MISSING_ARGS',
+});