crypto: allow monkey patching of pseudoRandomBytes

Make `pseudoRandomBytes` and it's aliases `prng` and `rng` configurable to allow monkey patching. PR-URL: #24108 Refs: #22519 Refs: #23017 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Nov 28, 2018 · 16d7060 · 16d7060
1 parent 091238a
commit 16d7060
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/crypto.js b/lib/crypto.js
@@ -247,19 +247,25 @@ Object.defineProperties(exports, {
   // The ecosystem needs those to exist for backwards compatibility.
   prng: {
     enumerable: false,
+    configurable: true,
+    writable: true,
     value: pendingDeprecation ?
       deprecate(randomBytes, 'crypto.prng is deprecated.', 'DEP0115') :
       randomBytes
   },
   pseudoRandomBytes: {
     enumerable: false,
+    configurable: true,
+    writable: true,
     value: pendingDeprecation ?
       deprecate(randomBytes,
                 'crypto.pseudoRandomBytes is deprecated.', 'DEP0115') :
       randomBytes
   },
   rng: {
     enumerable: false,
+    configurable: true,
+    writable: true,
     value: pendingDeprecation ?
       deprecate(randomBytes, 'crypto.rng is deprecated.', 'DEP0115') :
       randomBytes

diff --git a/test/parallel/test-crypto-random.js b/test/parallel/test-crypto-random.js
@@ -306,3 +306,12 @@ assert.throws(
     }
   );
 });
+
+
+['pseudoRandomBytes', 'prng', 'rng'].forEach((f) => {
+  const desc = Object.getOwnPropertyDescriptor(crypto, f);
+  assert.ok(desc);
+  assert.strictEqual(desc.configurable, true);
+  assert.strictEqual(desc.writable, true);
+  assert.strictEqual(desc.enumerable, false);
+});