Skip to content

Commit

Permalink
test: mark test_threadsafe_function/test as flaky
Browse files Browse the repository at this point in the history
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.

Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
gireeshpunathil authored and BridgeAR committed Dec 5, 2018
1 parent 0148c1d commit 10c2773
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions test/addons-napi/addons-napi.status
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
prefix addons-napi

# To mark a test as flaky, list the test name in the appropriate section
# below, without ".js", followed by ": PASS,FLAKY". Example:
# sample-test : PASS,FLAKY

[true] # This section applies to all platforms

[$system==win32]
# https://github.com/nodejs/node/issues/23621
test_threadsafe_function/test: PASS,FLAKY

0 comments on commit 10c2773

Please sign in to comment.