test_runner: assert entry is a valid object

PR-URL: #55231 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs · Oct 9, 2024 · 0f7e3f0 · 0f7e3f0
1 parent f0b4412
commit 0f7e3f0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/internal/test_runner/test.js b/lib/internal/test_runner/test.js
@@ -560,7 +560,7 @@ class Test extends AsyncResource {
         const map = lazyFindSourceMap(this.loc.file);
         const entry = map?.findEntry(this.loc.line - 1, this.loc.column - 1);
 
-        if (entry !== undefined) {
+        if (entry?.originalSource !== undefined) {
           this.loc.line = entry.originalLine + 1;
           this.loc.column = entry.originalColumn + 1;
           this.loc.file = entry.originalSource;

diff --git a/test/parallel/test-runner-enable-source-maps-issue.js b/test/parallel/test-runner-enable-source-maps-issue.js
@@ -0,0 +1,16 @@
+'use strict';
+require('../common');
+const assert = require('node:assert');
+const { spawnSync } = require('node:child_process');
+const { test } = require('node:test');
+const fixtures = require('../common/fixtures');
+
+test('ensures --enable-source-maps does not throw an error', () => {
+  const fixture = fixtures.path('test-runner', 'coverage', 'stdin.test.js');
+  const args = ['--enable-source-maps', fixture];
+
+  const result = spawnSync(process.execPath, args);
+
+  assert.strictEqual(result.stderr.toString(), '');
+  assert.strictEqual(result.status, 0);
+});