inspector: introduce a smoke test

This test executes a simple debug session over the inspector protocol. PR-URL: #8429 Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]>
nodejs · Sep 30, 2016 · 0b90ff7 · 0b90ff7
1 parent 3222b66
commit 0b90ff7
Show file tree

Hide file tree

Showing 10 changed files with 630 additions and 6 deletions.
diff --git a/Makefile b/Makefile
@@ -119,7 +119,7 @@ test: all
 	$(MAKE) build-addons
 	$(MAKE) cctest
 	$(PYTHON) tools/test.py --mode=release -J \
-		addons doctool known_issues message pseudo-tty parallel sequential
+		addons doctool inspector known_issues message pseudo-tty parallel sequential
 	$(MAKE) lint
 
 test-parallel: all
@@ -193,7 +193,7 @@ test-all-valgrind: test-build
 	$(PYTHON) tools/test.py --mode=debug,release --valgrind
 
 CI_NATIVE_SUITES := addons
-CI_JS_SUITES := doctool known_issues message parallel pseudo-tty sequential
+CI_JS_SUITES := doctool inspector known_issues message parallel pseudo-tty sequential
 
 # Build and test addons without building anything else
 test-ci-native: | test/addons/.buildstamp
@@ -233,6 +233,9 @@ test-internet: all
 test-debugger: all
 	$(PYTHON) tools/test.py debugger
 
+test-inspector: all
+	$(PYTHON) tools/test.py inspector
+
 test-known-issues: all
 	$(PYTHON) tools/test.py known_issues
 

diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -48,6 +48,7 @@ void PrintDebuggerReadyMessage(int port) {
     "@%s/inspector.html?"
     "experiments=true&v8only=true&ws=localhost:%d/node\n",
       port, DEVTOOLS_HASH, port);
+  fflush(stderr);
 }
 
 bool AcceptsConnection(inspector_socket_t* socket, const std::string& path) {
@@ -525,6 +526,7 @@ bool AgentImpl::IsStarted() {
 void AgentImpl::WaitForDisconnect() {
   shutting_down_ = true;
   fprintf(stderr, "Waiting for the debugger to disconnect...\n");
+  fflush(stderr);
   inspector_->runMessageLoopOnPause(0);
 }
 
@@ -620,6 +622,7 @@ bool AgentImpl::OnInspectorHandshakeIO(inspector_socket_t* socket,
     return false;
   default:
     UNREACHABLE();
+    return false;
   }
 }
 

diff --git a/src/inspector_socket.cc b/src/inspector_socket.cc
@@ -33,7 +33,7 @@ static void dump_hex(const char* buf, size_t len) {
   while (ptr < end) {
     cptr = ptr;
     for (i = 0; i < 16 && ptr < end; i++) {
-      printf("%2.2X  ", *(ptr++));
+      printf("%2.2X  ", static_cast<unsigned char>(*(ptr++)));
     }
     for (i = 72 - (i * 4); i > 0; i--) {
       printf(" ");

diff --git a/test/README.md b/test/README.md
@@ -54,6 +54,15 @@ Tests for garbage collection related functionality.
 |:----------:|
 | No         |
 
+
+### inspector
+
+Tests for the V8 inspector integration.
+
+| Runs on CI |
+|:----------:|
+| Yes        |
+
 ### internet
 
 Tests that make real outbound connections (mainly networking related modules).

diff --git a/test/fixtures/loop.js b/test/fixtures/loop.js
@@ -0,0 +1,10 @@
+var t = 1;
+var k = 1;
+console.log('A message', 5);
+while (t > 0) {
+  if (t++ === 1000) {
+    t = 0;
+    console.log('Outputed message #' + k++);
+  }
+}
+process.exit(55);