tools: fix eslint usage for Node.js 8 and before

IDEs like vscode use older Node.js versions that do not yet support the new try catch syntax. This makes sure eslint continues to work in these IDEs as before. PR-URL: #24753 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Dec 5, 2018 · 09cd2ec · 09cd2ec
1 parent 807c108
commit 09cd2ec
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -17,7 +17,10 @@ Module._findPath = (request, paths, isMain) => {
   if (!r && hacks.includes(request)) {
     try {
       return require.resolve(`./tools/node_modules/${request}`);
-    } catch {
+    // Keep the variable in place to ensure that ESLint started by older Node.js
+    // versions work as expected.
+    // eslint-disable-next-line no-unused-vars
+    } catch (e) {
       return require.resolve(
         `./tools/node_modules/eslint/node_modules/${request}`);
     }