url: handle quasi-WHATWG URLs in urlToOptions()

PR-URL: #26226 Refs: #26198 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Mar 1, 2019 · 0017855 · 0017855
1 parent 0080350
commit 0017855
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1257,13 +1257,13 @@ function domainToUnicode(domain) {
 function urlToOptions(url) {
   var options = {
     protocol: url.protocol,
-    hostname: url.hostname.startsWith('[') ?
+    hostname: typeof url.hostname === 'string' && url.hostname.startsWith('[') ?
       url.hostname.slice(1, -1) :
       url.hostname,
     hash: url.hash,
     search: url.search,
     pathname: url.pathname,
-    path: `${url.pathname}${url.search}`,
+    path: `${url.pathname || ''}${url.search || ''}`,
     href: url.href
   };
   if (url.port !== '') {

diff --git a/test/parallel/test-whatwg-url-custom-properties.js b/test/parallel/test-whatwg-url-custom-properties.js
@@ -133,8 +133,8 @@ assert.strictEqual(url.searchParams, oldParams);
 
 // Test urlToOptions
 {
-  const opts =
-    urlToOptions(new URL('http://user:[email protected]:21/aaa/zzz?l=24#test'));
+  const urlObj = new URL('http://user:[email protected]:21/aaa/zzz?l=24#test');
+  const opts = urlToOptions(urlObj);
   assert.strictEqual(opts instanceof URL, false);
   assert.strictEqual(opts.protocol, 'http:');
   assert.strictEqual(opts.auth, 'user:pass');
@@ -147,6 +147,23 @@ assert.strictEqual(url.searchParams, oldParams);
 
   const { hostname } = urlToOptions(new URL('http://[::1]:21'));
   assert.strictEqual(hostname, '::1');
+
+  // If a WHATWG URL object is copied, it is possible that the resulting copy
+  // contains the Symbols that Node uses for brand checking, but not the data
+  // properties, which are getters. Verify that urlToOptions() can handle such
+  // a case.
+  const copiedUrlObj = Object.assign({}, urlObj);
+  const copiedOpts = urlToOptions(copiedUrlObj);
+  assert.strictEqual(copiedOpts instanceof URL, false);
+  assert.strictEqual(copiedOpts.protocol, undefined);
+  assert.strictEqual(copiedOpts.auth, undefined);
+  assert.strictEqual(copiedOpts.hostname, undefined);
+  assert.strictEqual(copiedOpts.port, NaN);
+  assert.strictEqual(copiedOpts.path, '');
+  assert.strictEqual(copiedOpts.pathname, undefined);
+  assert.strictEqual(copiedOpts.search, undefined);
+  assert.strictEqual(copiedOpts.hash, undefined);
+  assert.strictEqual(copiedOpts.href, undefined);
 }
 
 // Test special origins