Exposing pkey, cert from crypto context to js land

[ssuda]

This will solve exposing pkey, cert from pkcs12/pfx to js
issue #4050

[indutny]

Why not just .getKey() and .getCert()? Also your patch is very unclean (commented lines, etc).

[bnoordhuis]

@ssuda Can you fix the style issues first?

[ssuda]

Styling issues were fixed

[ssuda]

@bnoordhuis please review this

[bnoordhuis]

Style: if arguments don't fit on a single line, make them line up, one per line.

[bnoordhuis]

Some style issues but the basic concept seems sound. I agree with @indutny though, it should use functions instead of a getter/setter.

[ssuda]

@bnoordhuis, style issues were fixed. To make them enumerable I am going with properties rather than Get/Set functions

[bnoordhuis]

To make them enumerable I am going with properties rather than Get/Set functions

That's very much unlike anything else in the crypto API.

[isaacs]

I agree with @bnoordhuis and @indutny here. No magic getter/setter accessors. We do those sorts of shenanigans as a last resort only. Put that in a userland JS module if you'd prefer that style.

[Nodejs-Jenkins]

Can one of the admins verify this patch?

[chrisdickinson]

Closing this -- the patch is way out of date with the v0.12 branch.