This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Cluster 2.0 - step 6 : Add disconnect methods to graceful shutdown #2740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is important that a worker can die graceful so no connected clients are interrupted. This patch adds:
worker.disconnect()
stop server from accepting new connections, and close the IPC channel when all connection are ended. The documentation include an example on how to make a timeout.cluster.disconnect()
runworker.disconnect()
and all living workers and then close the handlers create in master allowing the cluster to die graceful.worker.on('disconnect')
emits when IPC channel is closed.cluster.on('disconnect')
same asworker.on('disconnect')
just global this follow the existing pattern.There was an related issue to this: #2088
This is about the merging in the good parts from the
cluster 2.0
( see #2038 ) pull request