From f3f4e282168d243610f8e0241d633ff941c9c260 Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Wed, 18 Mar 2015 02:57:39 -0400 Subject: [PATCH] test: make cluster tests more time tolerant simple tests test-cluster-master-error.js, test-cluster-master-kill.js fails in AIX with assertion failure indicating that the workers were alive even after the master terminated. A 200ms leeway is provided for the workers to actually terminate, but the isAlive check returns true in both the cases. In AIX, the workers were actually terminating, but they took more time - as much as 800ms (normal) to 1000ms (in rare cases). Based on a C test we ran, it is found that the exit routines in AIX is a bit more longer than that in Linux. There are a number of cleanup activities performed in exit() system call, and depending on when the signal handlers are shutdown in that sequence, the process will be deemed as dead or alive, from another process's perspective. process.kill(pid) is used in the test case to check the liveliness of the worker, and when the kill() call is issued, even if the target process is in it's exit sequences, if the signal handlers are not shut down, it will respond to external signals, causing those calls to pass. This fix extends the additional timeout for all platforms Reviewed-By: Michael Dawson PR-URL: https://github.com/joyent/node/pull/9431 --- test/simple/test-cluster-master-error.js | 2 +- test/simple/test-cluster-master-kill.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/simple/test-cluster-master-error.js b/test/simple/test-cluster-master-error.js index ee2ed9eb4ee..3bb980431f8 100644 --- a/test/simple/test-cluster-master-error.js +++ b/test/simple/test-cluster-master-error.js @@ -114,7 +114,7 @@ if (cluster.isWorker) { existMaster = !!code; // Give the workers time to shut down - setTimeout(checkWorkers, 200); + setTimeout(checkWorkers, 1000); function checkWorkers() { // When master is dead all workers should be dead to diff --git a/test/simple/test-cluster-master-kill.js b/test/simple/test-cluster-master-kill.js index 36254039039..46189696fb4 100644 --- a/test/simple/test-cluster-master-kill.js +++ b/test/simple/test-cluster-master-kill.js @@ -82,7 +82,7 @@ if (cluster.isWorker) { // check worker process status setTimeout(function() { alive = isAlive(pid); - }, 200); + }, 1000); }); process.once('exit', function() {