Setting NODE_GYP_DIR for addon.gypi to setting absolute path for src/… #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +21,7 @@ var log = require('npmlog') | |||
| var prog = gyp() | |||
| var completed = false | |||
| prog.parseArgv(process.argv) | |||
| process.env['NODE_GYP_DIR'] = path.resolve(__dirname, '..'); | |||
There was a problem hiding this comment.
We should set this as a variable in config.gypi, rather than as an env variable.
There was a problem hiding this comment.
That's not possible, because NODE_GYP_DIR is calculated.
cause gypi can not retrieve the current directory.
There was a problem hiding this comment.
hope for fast response...
…win_delay_load_hook.c, and fixes of the long relative path issue on Win32. Fixes of nodejs#636
|
Updated. |
|
Much better now! Thanks! |
TooTallNate
added a commit
that referenced
this pull request
May 31, 2015
Setting NODE_GYP_DIR for addon.gypi to setting absolute path for src/…
|
Unfortunately this breaks MSBuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…win_delay_load_hook.c,
and fixes of the long relative path issue on Win32.
Fixes of #636