Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release with ARM64 Windows support #1764

Closed
jkunkee opened this issue May 30, 2019 · 1 comment
Closed

Make release with ARM64 Windows support #1764

jkunkee opened this issue May 30, 2019 · 1 comment

Comments

@jkunkee
Copy link
Contributor

jkunkee commented May 30, 2019

Summary: Please cut a node-gyp release with full ARM64 support within the next few weeks so it can make it downstream to Electron 6.


What changes? #1655, #1679, and #1739

Who and Why? I am working at Microsoft in tandem with a couple of our partners to bring ARM64 Windows support to Electron 6. Per nodejs/node#25998, this requires making a node-gyp release with these changes so that the release can be consumed downstream (in npm and thence in Node.js proper).

When? Electron 6 has a major release coming up, Electron 6 is based on Node.js v12, and it will take some time to get npm and Node.js and Node.js v12 to receive these changes, so I am really hoping for this to happen in the next three weeks or so.

How? Landing these three changes in the v5.0.0 release proposal, #1723, would be fine, and @joaocgreis has already made the request there.

If v5.0.0 needs more time due, perhaps, to requests for Python 3 and VS 2019 support, these three changes could (I believe) stand alone and so could be part of a v4.1.0 or even a v4.0.1 release.


I'm happy to help this happen any way I can and figured posting an issue would be a good start.

@jkunkee
Copy link
Contributor Author

jkunkee commented Jun 14, 2019

This is resolved by the v5.0.0 release in #1723. Thanks @rvagg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant