Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"python": "^2.7" should be defined in "engines" field of node-gyp/package.json #1545

Closed
hulkish opened this issue Sep 16, 2018 · 3 comments
Closed

Comments

@hulkish
Copy link

hulkish commented Sep 16, 2018

This would be helpful to know during the install phase of node-gyp. Is there any reason not to fo this?

@refack
Copy link
Contributor

refack commented Sep 16, 2018

The only issue that might arise is that node-gyp is a dep of npm and if it fails, AFAIR it will propagate to fail npm. For most users that's an unneeded fails.

@hulkish
Copy link
Author

hulkish commented Sep 16, 2018

@refack I admit this is not specifically a node-gyp concern. I guess the question is how are we intended to communicate these kinds of requirements?

For example, if you don't know that python is required when you install node-gyp - you only learn so when trying (and failing) to actually use node-gyp. Which, I think it might be better to at least emit a warning on the install phase.

This is especially easy to run into if for example you are constructing a custom node image.

@refack
Copy link
Contributor

refack commented Sep 16, 2018

Which, I think it might be better to at least emit a warning on the install phase.

That's a nice idea. If you have the time to submit a PR to hook script: {install}, that would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants