From 88260bf86aeb4c39959b78104a5edc3dc88d3aef Mon Sep 17 00:00:00 2001 From: Stefan Stojanovic Date: Fri, 29 Nov 2024 11:56:42 +0100 Subject: [PATCH] feat: prohibit compiling with ClangCL on Windows (#3098) Disables trying to compile with ClangCL on Windows. Was required to enable native tests in the Node.js CI for the ClangCL produced binaries. Refs: https://github.com/nodejs/node/pull/55784 --- lib/create-config-gypi.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/create-config-gypi.js b/lib/create-config-gypi.js index d598dea6e2..01a820e9f2 100644 --- a/lib/create-config-gypi.js +++ b/lib/create-config-gypi.js @@ -96,6 +96,9 @@ async function getCurrentConfigGypi ({ gyp, nodeDir, vsInfo, python }) { } } variables.msbuild_path = vsInfo.msBuild + if (config.variables.clang === 1) { + config.variables.clang = 0 + } } // loop through the rest of the opts and add the unknown ones as variables.