From f8a6a08ba8d57585559b4ca9b41c94feb14cdf1c Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 12:34:58 -0200 Subject: [PATCH 1/7] Update number.md The docs are apparently wrong when comparing to the string ones. Hope it is correct. If any other changes are required, please tell me and I'll be more than happy to change. --- doc/number.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/number.md b/doc/number.md index 8226909a8..d697160ac 100644 --- a/doc/number.md +++ b/doc/number.md @@ -37,7 +37,7 @@ Napi::Number(napi_env env, napi_value value); Napi::Number Napi::Number::New(napi_env env, double value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Nuber` object. - - `[in] value`: The `napi_value` which is a handle for a JavaScript `Number`. + - `[in] value`: The C++ primitive from which to instantiate the Napi::Value. value must be a `c++ double`. Creates a new instance of a `Napi::Number` object. From 5afccb2b866f9a11f018f73da8c32cc7621b0964 Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 12:36:24 -0200 Subject: [PATCH 2/7] Update number.md --- doc/number.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/number.md b/doc/number.md index d697160ac..34df116c3 100644 --- a/doc/number.md +++ b/doc/number.md @@ -37,7 +37,7 @@ Napi::Number(napi_env env, napi_value value); Napi::Number Napi::Number::New(napi_env env, double value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Nuber` object. - - `[in] value`: The C++ primitive from which to instantiate the Napi::Value. value must be a `c++ double`. + - `[in] value`: The C++ primitive from which to instantiate the `Napi::Value`. `value` must be a `c++ double`. Creates a new instance of a `Napi::Number` object. From 77bcf0746e9917ea45bec205f928387879b3d41a Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 12:38:41 -0200 Subject: [PATCH 3/7] Update number.md --- doc/number.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/number.md b/doc/number.md index 34df116c3..84d25b7a4 100644 --- a/doc/number.md +++ b/doc/number.md @@ -25,7 +25,8 @@ Napi::Number(napi_env env, napi_value value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Nuber` object. - - `[in] value`: The `napi_value` which is a handle for a JavaScript `Number`. + - `[in] value` - The primitive to wrap. + Returns a non-empty `Napi::Number` object. From 0c6720eb427874cb95b5bcd993764d94bc7ac2d6 Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 12:39:48 -0200 Subject: [PATCH 4/7] Update number.md --- doc/number.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/number.md b/doc/number.md index 84d25b7a4..b366f04cc 100644 --- a/doc/number.md +++ b/doc/number.md @@ -25,7 +25,7 @@ Napi::Number(napi_env env, napi_value value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Nuber` object. - - `[in] value` - The primitive to wrap. + - `[in] value`: The primitive to wrap. Returns a non-empty `Napi::Number` object. From 2109e18124717f8d3efeb7892016d3707f533788 Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 12:40:33 -0200 Subject: [PATCH 5/7] Update number.md Typo. --- doc/number.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/number.md b/doc/number.md index b366f04cc..c94c20aa0 100644 --- a/doc/number.md +++ b/doc/number.md @@ -24,7 +24,7 @@ Creates a new instance of a `Napi::Number` object. Napi::Number(napi_env env, napi_value value); ``` - - `[in] env`: The `napi_env` environment in which to construct the `Napi::Nuber` object. + - `[in] env`: The `napi_env` environment in which to construct the `Napi::Number` object. - `[in] value`: The primitive to wrap. @@ -37,7 +37,7 @@ Napi::Number(napi_env env, napi_value value); ```cpp Napi::Number Napi::Number::New(napi_env env, double value); ``` - - `[in] env`: The `napi_env` environment in which to construct the `Napi::Nuber` object. + - `[in] env`: The `napi_env` environment in which to construct the `Napi::Number` object. - `[in] value`: The C++ primitive from which to instantiate the `Napi::Value`. `value` must be a `c++ double`. Creates a new instance of a `Napi::Number` object. From 38f8c07e2954f911f979c947d9664e2068ef23f1 Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 15:27:39 -0200 Subject: [PATCH 6/7] Update number.md --- doc/number.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/number.md b/doc/number.md index c94c20aa0..14a41a85e 100644 --- a/doc/number.md +++ b/doc/number.md @@ -25,7 +25,7 @@ Napi::Number(napi_env env, napi_value value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Number` object. - - `[in] value`: The primitive to wrap. + - `[in] value`: The JavaScript value holding a number. Returns a non-empty `Napi::Number` object. @@ -38,7 +38,7 @@ Napi::Number(napi_env env, napi_value value); Napi::Number Napi::Number::New(napi_env env, double value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Number` object. - - `[in] value`: The C++ primitive from which to instantiate the `Napi::Value`. `value` must be a `c++ double`. + - `[in] value`: The C++ primitive from which to instantiate the `Napi::Value`. Creates a new instance of a `Napi::Number` object. From 2632983f1a79c643ca9ef55900c8f16d02b53113 Mon Sep 17 00:00:00 2001 From: Bernardo Heynemann Date: Mon, 28 Jan 2019 16:44:18 -0200 Subject: [PATCH 7/7] Update number.md --- doc/number.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/number.md b/doc/number.md index 14a41a85e..51a8b7af4 100644 --- a/doc/number.md +++ b/doc/number.md @@ -38,7 +38,7 @@ Napi::Number(napi_env env, napi_value value); Napi::Number Napi::Number::New(napi_env env, double value); ``` - `[in] env`: The `napi_env` environment in which to construct the `Napi::Number` object. - - `[in] value`: The C++ primitive from which to instantiate the `Napi::Value`. + - `[in] value`: The C++ primitive from which to instantiate the `Napi::Number`. Creates a new instance of a `Napi::Number` object.