From 7be6f146e14fdf22b86fd90c65230740ac44b3ce Mon Sep 17 00:00:00 2001 From: Jaeseok Yoon Date: Tue, 2 Oct 2018 09:13:04 +0900 Subject: [PATCH 1/2] Added package-lock.json file to gitignore ```npm install``` creates a ```package-lock.json``` to lock the versions of dependencies that are installed. They recommend to commit this file and that's what I usually do in other projects but I think we should gitignore it in CITGM. This will allow us to always test the latest version of our dependencies (especially in CI). --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index febbb5c96..6aaa42c0a 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ /node_modules /build +package-lock.json From b473278cde18dd00952975abb2f126e7a53a6fbf Mon Sep 17 00:00:00 2001 From: Jaeseok Yoon Date: Tue, 9 Oct 2018 20:40:26 +0900 Subject: [PATCH 2/2] Added npmrc for setting package-lock to false --- .gitignore | 1 - .npmrc | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 .npmrc diff --git a/.gitignore b/.gitignore index 6aaa42c0a..febbb5c96 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,2 @@ /node_modules /build -package-lock.json diff --git a/.npmrc b/.npmrc new file mode 100644 index 000000000..43c97e719 --- /dev/null +++ b/.npmrc @@ -0,0 +1 @@ +package-lock=false