Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release #347

Closed
6 tasks done
mhdawson opened this issue Sep 18, 2018 · 7 comments
Closed
6 tasks done

Next release #347

mhdawson opened this issue Sep 18, 2018 · 7 comments

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 18, 2018

I'm thinking we should do a release after we land

@NickNaso would you like to do the release when we are ready?

@NickNaso
Copy link
Member

NickNaso commented Sep 18, 2018

Yes I can do the release and I agree with all workflow.

@NickNaso
Copy link
Member

NickNaso commented Sep 24, 2018

The Make 'nothing' target a static library is necessary for check tool. I added this at list of tasks we need to accomplish before to do a new release.

@mhdawson
Copy link
Member Author

mhdawson commented Oct 2, 2018

@NickNaso list of what we wanted is now complete.

@NickNaso
Copy link
Member

NickNaso commented Oct 2, 2018

Ok later I will try to make a new release. If you want we can do together.

@mhdawson
Copy link
Member Author

mhdawson commented Oct 2, 2018

I'm pretty busy today and I'm happy for you to do it on your own unless you have questions/want me to review. I think you have the steps down from the last run-through.

So if you want to do it together lets find a time, but if you are happy to do it on your own go for it.

@NickNaso
Copy link
Member

NickNaso commented Oct 2, 2018

@mhdawson I'm starting to create a new release 1.5.0 @nodejs/n-api

@NickNaso
Copy link
Member

NickNaso commented Oct 3, 2018

I'm closing the issue because we just published the new release (1.5.0).

@NickNaso NickNaso closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants