From bc38a3894dd9ef4576bc0dd77a65c9901eaa981b Mon Sep 17 00:00:00 2001 From: Jonathan Cardoso Machado Date: Tue, 10 Dec 2024 11:20:44 -0300 Subject: [PATCH] fix: electron v28 build failure due to setAcessor not having compatible signature --- nan.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nan.h b/nan.h index 1ac7f742..e5032268 100644 --- a/nan.h +++ b/nan.h @@ -47,6 +47,7 @@ #define NODE_18_0_MODULE_VERSION 108 #define NODE_19_0_MODULE_VERSION 111 #define NODE_20_0_MODULE_VERSION 115 +#define ELECTRON_28_0_MODULE_VERSION 119 #ifdef _MSC_VER # define NAN_HAS_CPLUSPLUS_11 (_MSC_VER >= 1800) @@ -2624,7 +2625,7 @@ NAN_DEPRECATED inline void SetAccessor( , getter_ , setter_ , obj -#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 +#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 || NODE_MODULE_VERSION == ELECTRON_28_0_MODULE_VERSION , settings #endif , attribute @@ -2676,7 +2677,7 @@ inline void SetAccessor( , getter_ , setter_ , obj -#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 +#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 || NODE_MODULE_VERSION == ELECTRON_28_0_MODULE_VERSION , settings #endif , attribute