-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade to npm 2.10.1 #1763
Conversation
Every npm version bump requires a few patches to be floated on node-gyp for io.js compatibility. These patches are found in 03d1992, 5de334c, and da730c7. This commit squashes them into a single commit. PR-URL: nodejs#990 Reviewed-By: Ben Noordhuis <[email protected]>
Hmmm, the commits have the correct parents, I wonder why GitHub has them out-of order? @iarna is it possible you could squash the
(That would seem most reasonable to me, cc @piscisaureus) Edit: hmmm, I might just edit it to include mine / bert's signoff and a link to this PR, that's how it was done for the first patch. |
PR LGTM otherwise, tests seem fine, but:
I'm not really sure why one is pending, this seems new. (I don't have couchdb installed, is that why?) |
@Fishrock123: Yeah, the out of orderness was unexpected. Squashing those would be no trouble, do you still want me to do that or did you change your mind? |
@iarna I'd still like them squashed, but I'd also prefer to have general sign-off from bert, although the latter isn't strictly necessary. I can edit the commit message to add more details upon landing, the above message should do for the squashed commit. |
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background.
@Fishrock123 I just repushed with the commits squashed. |
PR-URL: #1763 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Thanks, landed in c54d057...d144e96 :) |
@iarna you may want to update your release wiki doc to use d144e96 (new delay-load hook squash) for the future. :) |
@Fishrock123 Will do! |
FYI, 2.1.0 is going out with just a note about the upgrade and links to the release notes, if you want "notable items" in the changelog here then they'll need to come in on the PR as we can't include the full release notes. |
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background. This commit is a combined squash of the following previous patches: ba93c58, 3bda6cb, 0d6d3dd. PR-URL: nodejs#1763 Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: nodejs/node#1763 Reviewed-By: Jeremiah Senkpiel <[email protected]>
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background. This commit is a combined squash of the following previous patches: ba93c58, 3bda6cb, 0d6d3dd. PR-URL: nodejs/node#1763 Reviewed-By: Jeremiah Senkpiel <[email protected]>
The delay-load hook allows node.exe/iojs.exe to be renamed. See efadffe for more background. This commit is a combined squash of the following previous patches: ba93c58, 3bda6cb, 0d6d3dd. PR-URL: nodejs/node#1763 Reviewed-By: Jeremiah Senkpiel <[email protected]>
The main thing 2.10.x brings is SPDX validation.
Plus what's in: #1658
Release notes are here:
r: @Fishrock123
r: @chrisdickinson