Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

What is a web server doing in the installer? #57

Closed
soegaard opened this issue Jun 11, 2019 · 6 comments
Closed

What is a web server doing in the installer? #57

soegaard opened this issue Jun 11, 2019 · 6 comments
Labels

Comments

@soegaard
Copy link

Why is this included in the installer?

https://github.com/nodejs/installer/blob/master/src/renderer/lib/examples.js

@ChALkeR
Copy link
Member

ChALkeR commented Jul 1, 2019

@soegaard That's not a web server, that's a string with code demonstrating how to build a web server.
That code is not executed, it's shown to user as text (because it is just text).

It's used in https://github.com/nodejs/installer/blob/master/src/renderer/components/RandomExample.jsx
to show code examples, which is then shown on the right panel here:
https://github.com/nodejs/installer/blob/master/src/renderer/components/RightPanel.jsx

@ChALkeR
Copy link
Member

ChALkeR commented Jul 1, 2019

Closing as answered, feel free to comment/reopen if there are more concerns about that.

@ChALkeR ChALkeR closed this as completed Jul 1, 2019
@soegaard
Copy link
Author

soegaard commented Jul 1, 2019

Yes exactly. Why is such an example in the installer?

The job of the installer is to download the zip-file, unpack it and copy the files to proper folders.
I don't see why an installer has examples of anything.

@Qard
Copy link
Member

Qard commented Jul 1, 2019

To be friendly and helpful for people new to Node.js. It presents a nice place for them to get started with trying it out once the install completes.

@soegaard
Copy link
Author

soegaard commented Jul 1, 2019

That makes sense.

In my defense I never got to see what happens when the installer is finished:

#13

@addaleax
Copy link
Member

addaleax commented Jul 1, 2019

@soegaard I don’t think this project (new installer) is going anywhere, at least until somebody picks it up again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants