-
Notifications
You must be signed in to change notification settings - Fork 36
Framework / compilation language #47
Comments
The html/flexbox was done at the beginning when trying out the new UI, we should definitely move to something more powerful. Actually I was thinking about keep it simple, and keep using es6 and adopt choo as frontend framework. Thoughts? |
I'm kind of against choo, but simply because I'd like to go with something popluar (read: easy to contribute to). How about just React? That seems like the closest we could get to the "most common demoniator" these days. |
I can agree with you, instead I was proposing choo because hey, standards! :) Any other opinion @nodejs/electron-installer? |
I'm torn, I like the simplicity of Choo (and I assume we're unlikely to need something complex). However I agree that the average contributor is likely to be more familiar with React, and Googleability is likely to be much better for it as it's a larger project. I think/hope that the total amount of front-end code stays manageable for a while, giving us the option to change. Given that choo is a lesser-known quantity to me (and I'm guessing the rest of us), why not try it, if someone raises a PR we can see what it looks like (and how easy to understand it is for an outsider). I guess the other question is whether we need a framework at all, but I think a PR will make that pretty clear. EDIT: or two PRs, one for React and one for Choo, and then we can discuss pros/cons with something concrete to go on, but maybe that's a waste of time. |
I'm with @felixrieseberg on this. React seems to be the most common choice nowadays and makes it super easy for others to contribute 👍 |
Let's put this to a vote. I'm pretty set on using one of the main frameworks, but we should just let democracy win here. If size is a concern, we could just go with Preact, which is widely more popular than Choo. That said, let's do this: React to this message with... Let's close this discussion in 72 hours (and move forward with whatever @nodejs/electron-installer as a group prefers). |
Well, it seems like React is it. Thanks everyone! |
I don't really care what pre-renderer is used, but it would be nice to avoid traditional MVC and go for a more data-loop driven architecture ala Flux. Might be a bit of a barrier at first though. |
Currently we are using native ES6 for all the code, are we going to consider using something like
typescript
(which we get for free withelectron-forge
) to write our main/renderer code?Also for discussion, in terms of the renderer currently using
flexboxgrid
and some standard HTML / CSS. How do people feel about a UI framework like angular / react or sticking with the super basic HTML layouts?Just thinking as the main process scaffolding comes in we may want to think about these kind of things early on in the process
The text was updated successfully, but these errors were encountered: