Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Framework / compilation language #47

Open
MarshallOfSound opened this issue Jun 26, 2017 · 8 comments
Open

Framework / compilation language #47

MarshallOfSound opened this issue Jun 26, 2017 · 8 comments

Comments

@MarshallOfSound
Copy link
Member

Currently we are using native ES6 for all the code, are we going to consider using something like typescript (which we get for free with electron-forge) to write our main/renderer code?

Also for discussion, in terms of the renderer currently using flexboxgrid and some standard HTML / CSS. How do people feel about a UI framework like angular / react or sticking with the super basic HTML layouts?

Just thinking as the main process scaffolding comes in we may want to think about these kind of things early on in the process

@delvedor
Copy link
Member

The html/flexbox was done at the beginning when trying out the new UI, we should definitely move to something more powerful.

Actually I was thinking about keep it simple, and keep using es6 and adopt choo as frontend framework. Thoughts?

@felixrieseberg
Copy link
Member

felixrieseberg commented Jul 17, 2017

I'm kind of against choo, but simply because I'd like to go with something popluar (read: easy to contribute to).

How about just React? That seems like the closest we could get to the "most common demoniator" these days.

@delvedor
Copy link
Member

I can agree with you, instead I was proposing choo because hey, standards! :)
I saw the dat desktop application and they did an awesome job with choo.

Any other opinion @nodejs/electron-installer?

@gibfahn
Copy link
Member

gibfahn commented Jul 20, 2017

I'm torn, I like the simplicity of Choo (and I assume we're unlikely to need something complex). However I agree that the average contributor is likely to be more familiar with React, and Googleability is likely to be much better for it as it's a larger project.

I think/hope that the total amount of front-end code stays manageable for a while, giving us the option to change.

Given that choo is a lesser-known quantity to me (and I'm guessing the rest of us), why not try it, if someone raises a PR we can see what it looks like (and how easy to understand it is for an outsider).

I guess the other question is whether we need a framework at all, but I think a PR will make that pretty clear.

EDIT: or two PRs, one for React and one for Choo, and then we can discuss pros/cons with something concrete to go on, but maybe that's a waste of time.

@MarshallOfSound
Copy link
Member Author

I'm with @felixrieseberg on this. React seems to be the most common choice nowadays and makes it super easy for others to contribute 👍

@felixrieseberg
Copy link
Member

Let's put this to a vote. I'm pretty set on using one of the main frameworks, but we should just let democracy win here. If size is a concern, we could just go with Preact, which is widely more popular than Choo.

That said, let's do this: React to this message with...
😄 for React
🎉 for Choo
❤️ for Preact

Let's close this discussion in 72 hours (and move forward with whatever @nodejs/electron-installer as a group prefers).

@felixrieseberg
Copy link
Member

Well, it seems like React is it. Thanks everyone!

@Fishrock123
Copy link
Contributor

I don't really care what pre-renderer is used, but it would be nice to avoid traditional MVC and go for a more data-loop driven architecture ala Flux. Might be a bit of a barrier at first though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants