This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Bump to 2.6.1 #279
Closed
Bump to 2.6.1 #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes parsing improvements to ensure closer HTTP spec conformance Adaption of nodejs/node@4f4c8ab: Author: James M Snell <[email protected]> Date: Wed Feb 3 17:28:48 2016 -0800 deps: update http-parser to version 2.6.1 includes parsing improvements to ensure closer HTTP spec conformance PR-URL: https://github.com/nodejs/node-private/pull/26 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
LGTM |
|
LGTM |
|
Feel free to merge if you think its ready! |
jasnell
added a commit
that referenced
this pull request
Feb 10, 2016
Includes parsing improvements to ensure closer HTTP spec conformance Adaption of nodejs/node@4f4c8ab: Author: James M Snell <[email protected]> Date: Wed Feb 3 17:28:48 2016 -0800 deps: update http-parser to version 2.6.1 includes parsing improvements to ensure closer HTTP spec conformance PR-URL: nodejs-private/node-private#26 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> PR-URL: #279 Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Feb 10, 2016
PR-URL: #279 Reviewed-By: James M Snell <[email protected]>
|
Landed! |
| * character or %x80-FF | ||
| **/ | ||
| #define IS_HEADER_CHAR(ch) \ | ||
| (ch == CR || ch == LF || ch == 9 || (ch > 31 && ch != 127)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@craig65535 ... the comment had been buried in my github notifications. Actually just saw it a few minutes after opening #283. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the bump from nodejs and fixes an issue with compiling tests.
/cc=@jasnell