Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove component in release tags and set release sha #233

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

lukekarrys
Copy link
Member

This sets last-release-sha to 7875642 which is the commit releasing 0.16.2. This config can be removed anytime in the future after the next release PR is merged.

This also sets "include-component-in-tag": false which should make release tags match the old pattern of only including the version prefixed with v.

Refs: #232

@lukekarrys
Copy link
Member Author

Opting for a quick merge here to see if it corrects #232.

@lukekarrys lukekarrys changed the title Remove component in release tags and set release sha chore: remove component in release tags and set release sha Mar 11, 2024
@lukekarrys lukekarrys merged commit 7e13b43 into main Mar 11, 2024
20 checks passed
@lukekarrys lukekarrys deleted the lk/release-please-take-2 branch March 11, 2024 20:03
@lukekarrys
Copy link
Member Author

I think it worked from looking at the workflow logs https://github.com/nodejs/gyp-next/actions/runs/8239001592/job/22531251496

But all the commits since the last release are chore so no release PR was created.

But I think 876ccaf / #226 should not be a chore? At least from the perspective of node-gyp it needs to be released to help fix some linting errors there.

@targos what do you think?

@lukekarrys
Copy link
Member Author

If the commit needs to change its message, Release Please allows this by editing the body of the original PR to include a BEGIN_COMMIT_OVERRIDE / END_COMMIT_OVERRIDE section. This only works if the PR was squash merged though. More info can be found in the docs: https://github.com/googleapis/release-please?tab=readme-ov-file#how-can-i-fix-release-notes

@targos
Copy link
Member

targos commented Mar 12, 2024

I wasn't aware that linter issues in this project may affect another one. Added the override section.

@targos
Copy link
Member

targos commented Mar 12, 2024

@lukekarrys
Copy link
Member Author

I wasn't aware that linter issues in this project may affect another one. Added the override section.

Thanks for the release. On this point, maybe it shouldn't affect node-gyp. Python is not my strong suit at all but there are probably changes we can make so that it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants