fix: support msvs_quote_cmd in ninja generator #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjiawen
reviewed
Aug 11, 2021
cclauss
requested changes
Aug 11, 2021
cclauss
reviewed
Aug 11, 2021
zcbenz
force-pushed
the
ninja_msvs_quote_cmd
branch
from
eaeb0a8
to
30e1456
Compare
zcbenz
force-pushed
the
ninja_msvs_quote_cmd
branch
from
30e1456
to
623c476
Compare
gengjiawen
approved these changes
Aug 12, 2021
|
@cclauss ping |
|
@cclauss ping. |
cclauss
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix came from https://codereview.chromium.org/10384100/, but it did not get into upstream gyp because Chromium was deprecating the uses of
msvs_quote_cmd.However Node.js still uses
msvs_quote_cmdin its gyp files and I don't see a good way to remove it, so we have to supportmsvs_quote_cmdin ninja generator if we want to build Node.js with ninja on Windows.