Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js Bot Permissions #1221

Open
nschonni opened this issue Feb 21, 2020 · 3 comments
Open

Node.js Bot Permissions #1221

nschonni opened this issue Feb 21, 2020 · 3 comments

Comments

@nschonni
Copy link
Member

Currently it looks like it has Write access, but the original idea was just for Read #670 (comment)
Is there a reason the Bot still needs Write access? It might change if #1008 goes forward, but right now it looks like it doesn't need it.

Right now it looks like it's only used by this repo, but with nodejs/admin#471 maybe it will be re-used

@LaurentGoderre
Copy link
Member

We just reused one that already existed. I think it would be fine getting a more restricted one for this one as long as it still has access to write comments

@nschonni
Copy link
Member Author

@LaurentGoderre now that I think of it, I don't think it even needs "Read", since it's a public repo, so any user should be able to make comments on the issues (that isn't locked).

@LaurentGoderre
Copy link
Member

True but it should still be a bot with a token. It could be a token with no special access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@LaurentGoderre @nschonni and others