Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diag WG Meeting - 2016-10-05 #64

Closed
joshgav opened this issue Sep 13, 2016 · 22 comments · Fixed by #68
Closed

Diag WG Meeting - 2016-10-05 #64

joshgav opened this issue Sep 13, 2016 · 22 comments · Fixed by #68

Comments

@joshgav
Copy link
Contributor

joshgav commented Sep 13, 2016

Time

05-Oct-2016 Wed UTC 19:00 (1 hour before CTC meeting)

Please add a 👍 to this post to indicate you'll be attending. Thanks!

Click for your local time.

Join/Watch

If you are primarily observing please use the YouTube channel; Hangouts limits the number of connections. You can interact from YouTube via chat.

Minutes


Proposed agenda

v8_inspector/chrome debugging protocol:

V8 TraceController

ES modules

  • patching modules after import not possible - how will APMs deal with this?

/cc @nodejs/diagnostics

@joshgav
Copy link
Contributor Author

joshgav commented Sep 13, 2016

Agenda is just a proposal at the moment based on things we've been discussing, let's hammer out further in this thread. Didn't want to block on getting on our calendars.

Please indicate if this time doesn't work, perhaps we can bump to the next week at the same time.

@joshgav
Copy link
Contributor Author

joshgav commented Sep 20, 2016

@nodejs/diagnostics - Can I get some +/-1's on the original post or some responses here re the proposed meeting and its agenda?

  • Is this a good time? What other times would be better?
  • Are these the right topics?
  • Should we hold till there are new issues or updates? Or is it important to have a monthly sync in any case?

Thanks!

@ofrobots
Copy link
Contributor

Yikes! It seems that benchmarking and diagnostics WG both have a meeting at the same time.

@joshgav
Copy link
Contributor Author

joshgav commented Sep 21, 2016

Well, let's go ahead and try for next week then. I think we should have a monthly touch point even if it's only to give updates and highlight issues, so I'll keep trying ✊ 😄 . What do others think?

Here are potential issues to discuss under our domain:

v8_inspector/chrome debugging protocol:

@roblourens @auchenberg - any items related to https://github.com/Microsoft/vscode-node-cdp-debug you'd like to discuss?

V8 TraceController

ES modules

  • patching modules after import not possible - how will APMs deal with this?

@joshgav joshgav changed the title Diag WG Meeting - 2016-09-21 Diag WG Meeting - 2016-09-28 Sep 21, 2016
@mhdawson
Copy link
Member

Is the meeting still on ? Neither the hangout nor the youtube link seems to be active

@watson
Copy link
Member

watson commented Sep 28, 2016

I'm getting a 403 when I try to join using the link in the description

@mhdawson
Copy link
Member

At this point I'm going to assume no meeting.

@joshgav
Copy link
Contributor Author

joshgav commented Sep 28, 2016

I didn't receive replies so didn't think we were on. Would you like to have this next week?

@ofrobots @matthewloring would you be able to attend next week? Most of the discussion would relate to updates to V8.

Thanks, and apologies for the confusion @mhdawson and @watson.

@watson
Copy link
Member

watson commented Sep 28, 2016

No worries. We should maybe set up a system to say that we can attend? Maybe just add a 👍 to the issue? My schedule looks pretty free next week

@joshgav
Copy link
Contributor Author

joshgav commented Sep 28, 2016

@watson

just add a 👍 to the issue?

👍 😄

@matthewloring
Copy link

I am happy to come give a TracingController update.

@joshgav
Copy link
Contributor Author

joshgav commented Sep 28, 2016

Thanks @matthewloring! That would be great.

I've updated the OP and will fix up the Hangouts on Air event too. See you at 12pm Pacific time next Wednesday, and thanks for your patience!

@joshgav joshgav changed the title Diag WG Meeting - 2016-09-28 Diag WG Meeting - 2016-10-05 Sep 28, 2016
@Qard
Copy link
Member

Qard commented Sep 28, 2016

Should also do 👎 if you can't attend, so there's a clear distinction between who can't go and who is unaware of the meeting.

@ofrobots
Copy link
Contributor

@joshgav I am out of office all of next week, but @matthewloring should be able to cover Trace Event. /cc @eugeneo, @pavelfeldman to see if they can attend for devtools coverage.

@joshgav
Copy link
Contributor Author

joshgav commented Oct 5, 2016

Reminder to all that we're on for today at 12pm Pacific.

@eugeneo @pavelfeldman with the merge of inspector into v8 proper, have you thought about how to enable other engines to utilize the same front-end components, as I was getting at in node#7393? /cc @digitalinfinity

@matthewloring looking forward to hearing about your progress on TraceController.

Doing my best to review open issues related to diagnostics today to help drive the conversation, please suggest discussion items here or during the meeting itself.

Thanks!

@AndreasMadsen
Copy link
Member

AndreasMadsen commented Oct 5, 2016

I will try and join today. I've haven't been very active lately, I think the highlights on the async wrap async hooks front are:

  • Name changed to async hooks :)
  • The AsyncWrap EPS has been accepted by the CTC. Just needs to to merged, perhaps with some minor corrections.
    • There is still some discussion about how Promises should behave. Short story: two things are required for the .then(cb) "callback" to be called. 1) calling .then() 2) calling done(result) in the promise, so which is the natural parent?
  • @trevnorris has opened a PR async_hooks initial implementation node#8531
  • @Fishrock123 has investigated the Timer behavior (with dprof), particularly active and enroll. A solution has been found and implemented.
  • .disable() no longer has a tree behavior (performance).
  • Missing Embedder API, focus right now is on performance (I guess)
  • Once Embedder API is in place, we should look into NAN integration.
  • I'm sure @trevnorris would like any updates on Promise/Microtask integration.

@watson
Copy link
Member

watson commented Oct 5, 2016

For people watching this thread, we seem to have a problem with the YouTube live stream but are continuing with the meeting for now

@jkrems
Copy link
Contributor

jkrems commented Oct 5, 2016

@watson Thanks for the update, was wondering if it was a problem on my end.

@AndreasMadsen
Copy link
Member

We have space in the Hangout, if somebody just want to watch.

@ofrobots
Copy link
Contributor

Is there a recording of the meeting available anywhere?

@joshgav
Copy link
Contributor Author

joshgav commented Oct 11, 2016

@ofrobots unfortunately no, we had problems with the original Hangouts link, somehow the attendees were bifurcated and only I was in the live stream. In retrospect I think it's because I lopped off a query parameter in the Hangouts URL, I'll be more careful about that next time.

The notes should be pretty complete in the Google Doc though.

@joshgav
Copy link
Contributor Author

joshgav commented Oct 27, 2016

notes in #68

@joshgav joshgav closed this as completed Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants