fix: add path to package.json in error message
#456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcanis
approved these changes
Apr 13, 2024
That's an issue we sometimes have with |
styfle
reviewed
Apr 13, 2024
styfle
reviewed
Apr 13, 2024
Co-authored-by: Steven <[email protected]>
styfle
approved these changes
Apr 14, 2024
merceyz
approved these changes
Apr 14, 2024
merceyz
reviewed
Apr 15, 2024
| @@ -419,7 +420,10 @@ it(`should refuse to run a different package manager within a configured project | |||
| process.env.FORCE_COLOR = `0`; | |||
|
|
|||
| await expect(runCli(cwd, [`pnpm`, `--version`])).resolves.toMatchObject({ | |||
| stdout: `Usage Error: This project is configured to use yarn\n\n$ pnpm ...\n`, | |||
| stdout: `Usage Error: This project is configured to use yarn because ${ | |||
| // ppath and xfs do not format Windows correctly, the regex fixes that: | |||
There was a problem hiding this comment.
You would use npath.fromPortablePath to handle that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to help someone who couldn't understand why they were getting this error message on an empty directory; turned out they had a
package.jsonin their home directory (no idea how it got there) that defined apackageManagerfield. I think adding some explanation would help.