fix: correctly set Dispatcher prototype for ProxyAgent
#451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an attempt to bundle only a subset of Undici code, we forgot to take some side-effect.
arcanis
reviewed
Apr 6, 2024
| import(`undici/lib/dispatcher/dispatcher.js`), | ||
| // @ts-expect-error internal module is untyped | ||
| import(`undici/lib/dispatcher/proxy-agent.js`), | ||
| ]); |
There was a problem hiding this comment.
Are we doing all that just to reclaim some bytes? It seems a little dangerous 🤔
There was a problem hiding this comment.
I've added tests, hopefully those ensure we'll catch bugs if this hack breaks again in the future.
onigoetz
reviewed
Apr 9, 2024
| )) as { default: typeof import('undici').ProxyAgent }; | ||
| if (ProxyAgent == null) { | ||
| // Doing a deep import here since undici isn't tree-shakeable | ||
| const [api, Dispatcher, _ProxyAgent] = await Promise.all([ |
There was a problem hiding this comment.
Do these need to be loaded in a particular order?
I would recommend putting them in a separate file and just exposing the ProxyAgent from that file and add a comment on why those files are needed.
There was a problem hiding this comment.
No, any order, that's why I'm loading them concurrently.
arcanis
approved these changes
Apr 12, 2024
merceyz
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to bundle only a subset of Undici code, we forgot to take some side-effect.
Fixes: #417
Closes: #449