Add package configuration instruction to readme #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Sep 26, 2022
Co-authored-by: Antoine du Hamel <[email protected]>
|
I've added the above suggestion and a couple of sentences explaining the contents of the config string. Might be good to go now. |
|
I think the docs should also mention where to find the SHA. Like, if you knew the version, how do you map it to a SHA? |
aduh95
reviewed
Oct 9, 2022
I feel like that should be left to each package manager documentation. |
from review suggestion Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #187
Disclaimer: this is a quick pass from someone not yet familiar with the software, but I think it's correct and an improvement over the status quo.