Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not use ~/.node as default value for COREPACK_HOME #152

Merged
merged 5 commits into from
Aug 15, 2022
Merged

feat: do not use ~/.node as default value for COREPACK_HOME #152

merged 5 commits into from
Aug 15, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 23, 2022

Fixes: #145
Refs: nodejs/node#43859

merceyz
merceyz requested changes Jul 23, 2022
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will essentially "clear" the state of Corepack on existing machines, we should probably see if ~/.node/corepack already exists and continue using it or "migrate" its data to the new location.

sources/folderUtils.ts Outdated Show resolved Hide resolved
@aduh95 aduh95 requested a review from arcanis July 31, 2022 12:08
@arcanis arcanis merged commit 09e24cf into main Aug 15, 2022
@arcanis arcanis deleted the xdg-spec-and-windows-appdata branch August 15, 2022 18:35
@github-actions github-actions bot mentioned this pull request Aug 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz requested changes

@arcanis arcanis arcanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow XDG Specification
3 participants
@aduh95 @arcanis @merceyz