Windows release job failing on vs2015-x86

[mhdawson]

This seems to have failed the most recent couple of nightly builds. Looks like it passed on an earlier one (Mar 23)

https://ci-release.nodejs.org/job/iojs+release/

       [
              _Ty=v8::CpuProfileDeoptInfo
          ]
  c:\ws\deps\v8\include/v8-profiler.h(44): note: see reference to class template instantiation 'std::vector<v8::CpuProfileDeoptInfo,std::allocator<_Ty>>' being compiled
          with
          [
              _Ty=v8::CpuProfileDeoptInfo
          ]
     Creating library c:\ws\Release\mksnapshot.lib and object c:\ws\Release\mksnapshot.exp
v8_base_0.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForId(enum v8::internal::Runtime::FunctionId)" (?FunctionForId@Runtime@internal@v8@@SAPBUFunction@123@W4FunctionId@123@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForName(unsigned char const *,int)" (?FunctionForName@Runtime@internal@v8@@SAPBUFunction@123@PBEH@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::RuntimeFunctionTable(class v8::internal::Isolate *)" (?RuntimeFunctionTable@Runtime@internal@v8@@SAPBUFunction@123@PAVIsolate@23@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForEntry(unsigned char *)" (?FunctionForEntry@Runtime@internal@v8@@SAPBUFunction@123@PAE@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(js-operator.obj) : error LNK2001: unresolved external symbol "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum v8::internal::Runtime::FunctionId)" (??6internal@v8@@YAAAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AAV23@W4FunctionId@Runtime@01@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
c:\ws\Release\mksnapshot.exe : fatal error LNK1120: 5 unresolved externals [c:\ws\deps\v8\src\mksnapshot.vcxproj]
Build step 'Conditional steps (multiple)' marked build as failure
Skipped archiving because build is not successful
Sending e-mails to: [email protected] [email protected]
Notifying upstream projects of job completion
Finished: FAILURE

[mhdawson]

@joaocgreis

[joaocgreis]

This was tracked and fixed for x64 in nodejs/v8#4 .

We don't have 32 bit builds in the test CI because we don't have real 32 bit VMs, but this issue makes a very good case for adding WoW64 somewhere in the matrix.

[kunalspathak]

We don't have 32 bit builds in the test CI

Is it possible to pass x86 to vcbuild.bat and that should trigger 32 bit builds or is it that it won't simulate the behavior we would get while running on Wow64?

[joaocgreis]

Yes, that's even how we do the x86 releases. But we don't have 32 bit machines to test a 32 bit node.exe natively, WoW64 will have to do.

[joaocgreis]

Added a x86 build to the test matrix to node-compile-windows on VS2015. The resulting 32 bit binary is tested on the 64 bit Windows 2008 machines. Test runs:

• master ✔️
• v7.x-staging ✔️ (one failed test but not on the x86 build)
• v6.x-staging ✔️
• v4.x-staging ✔️