-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop modules.nodejs.org and packages.nodejs.org CNAME mappings? #3395
Comments
It would be nice to know when they stopped working, but I think we can just drop them. |
My guess is they stopped working when npm moved from fastly to cloudflare, many many years ago. The same thing happened to yarn's "registry" when we made the move. I have pinged our registry/infrastructure team to see if there was any recent change here just in case. Putting my security hat on it's probably best not to CNAME out to infrastructure you don't own or control. Deleting these would be best. |
+1 to delete |
I see no problem with removing these. |
We have CNAME mappings for modules.nodejs.org and packages.nodejs.org in our Cloudflare account. These supposedly redirect to npmjs.org, but are not working due to Cloudflare's security policy:
We could replace these with Cloudflare Page Rules but we only have a limited number of those (13 left out of 50 and we'll need some of those for #3366). As far as I know we have had no reports/complaints about either of the two broken mappings and I can't find references to either of them in GitHub for the nodejs org -- perhaps we should just drop them completely and fall back to the generic subdomain mapping back to the nodejs.org website?
cc @nodejs/build-infra FYI @nodejs/tsc @nodejs/npm
Refs: #3391 (comment)
Refs: #3391 (comment)
The text was updated successfully, but these errors were encountered: