-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows authenticode certification expiry #2415
Comments
I've emailed @brianwarner (and included @joaocgreis) to loop him in so that the Foundation can pay directly like we did in some other cases recently. |
Have a meeting tomorrow to see if @brianwarner and me can renew. |
@rvagg I got together with Brian today but I need a bit more help/context to complete the renewal. Specifically its asking for a CSR as part of the renewal. I've found the file " Node.js Foundation Microsoft Authenticode Certificate.txt" which I can decode and get the p12 from. From there I can get the private key. A few questions
|
OK, considering that years have now gone by, this is off the top of my head and with very little memory of how this all went down originally:
|
Cool, thanks @rvagg. On 3), we followed Digicert's advice to handle an organizational name change by adding a new org vs. replacing an existing one. I've let LF folks know they may be getting a verification request. Worst comes to worst, we can renew for a year on the old name and then deal with it again next year. |
They're saying new https://docs.digicert.com/manage-certificates/code-signing-certificate/renew-code-signing-certificate/ |
@nschonni it says best practice is to "generate a new CSR", that's different than generating a new private key unless I missed something. |
@joaocgreis can you chime on on using a new versus the existing private key and what needs to be installed once we get the new certificate? |
@mhdawson when we renewed 3 years ago I had to install the new certificate in every machine, so I don't think the private key makes any difference. I can install the certificate when you have it, please update the secrets and let me know. Essentially, it's just remove the old one, install the new one, and test building to make sure everything is ok. Note this is only for the release machines. |
ok So I'll create a new key, and then request the cert. |
Certificate requested, will update when we receive the response |
On with chat support at Digicert, seems we still need the verification process to support. They need to call the public number for the foundation. Unfortunately there was no answer when I tried, so suggested the leave a message to have them call back. Will ping Brian to hopefully make sure they know the context. |
Yes, it's a voicemail line, so they need to leave a message for a callback. They can also call me directly, if that's sufficient. |
Still looks like it is in pending, trying to contact support again. |
Called in to support again today. What I've been told is that they called the Foundation number and left a code which somebody needs to call back with in order to complete the validation. @brianwarner I think I need you to follow up on that |
Received the email today with the cert, have raised to update in the secrets repo. @joaocgreis over to you to update the servers with the new p12 file. |
Updated, done. Thanks @mhdawson |
@joaocgreis I suspect the new certificate is behind Windows flagging the most recent installers as unsafe: nodejs/node#35539 |
I have reported the files as safe, let's see if it solves the issue. |
iirc it took a few days of our original cert in the wild and enough people to mark their installs as OK for Microsoft to start flagging it as OK |
It's going to be ~$1.5k to renew for 3 years I think. This will need someone with access and who wants to interact with the foundation to drive it forward and get a renewal. There is also the question about renaming the Foundation name too like we've been looking at for our Apple account.
The text was updated successfully, but these errors were encountered: