Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv,arm64: add arm64 buildbots to matrix #1971

Closed
bnoordhuis opened this issue Oct 19, 2019 · 9 comments
Closed

libuv,arm64: add arm64 buildbots to matrix #1971

bnoordhuis opened this issue Oct 19, 2019 · 9 comments

Comments

@bnoordhuis
Copy link
Member

See libuv/libuv#2522 and nodejs/node#29996. Node.js is tested against arm64 but libuv isn't, allowing a compile time error to slip through.

@rvagg
Copy link
Member

rvagg commented Oct 20, 2019

k, I've added them to libuv-test-commit-linux, https://ci.nodejs.org/view/libuv/job/libuv-test-commit-linux/1671/

  • centos7-arm64-gcc48
  • centos7-arm64-gcc6
  • ubuntu1604-arm64

I've added the logic into the job that selects the devtoolset to enable gcc6 and that appears to be working, at least according to the gcc output.

But you have persistent failures on those centos machines that will need addressing:

not ok 347 - udp_multicast_join
# timeout
# Output from process `udp_multicast_join`: (no output)
not ok 348 - udp_multicast_join6
# timeout
# Output from process `udp_multicast_join6`: (no output)

You have access to those machines, see inventory.yml, so feel free to get in and poke around. If we need changes to the machine configs then let's get something into ansible for it.

@rvagg
Copy link
Member

rvagg commented Oct 20, 2019

@joaocgreis are windows arm64 machines able to be added here too?

@richardlau
Copy link
Member

But you have persistent failures on those centos machines that will need addressing:

not ok 347 - udp_multicast_join
# timeout
# Output from process `udp_multicast_join`: (no output)
not ok 348 - udp_multicast_join6
# timeout
# Output from process `udp_multicast_join6`: (no output)

You have access to those machines, see inventory.yml, so feel free to get in and poke around. If we need changes to the machine configs then let's get something into ansible for it.

Possibly related to #1879?

@cjihrig
Copy link
Contributor

cjihrig commented Oct 20, 2019

Possibly related to #1879?

I believe that's correct, based on libuv/libuv#2468 (comment).

@rvagg
Copy link
Member

rvagg commented Oct 20, 2019

🤦‍♂ ok, that's on me then, an overdue TODO, will try and get it sorted today

@rvagg
Copy link
Member

rvagg commented Oct 21, 2019

got firewalld sorted and got a green on https://ci.nodejs.org/view/libuv/job/libuv-test-commit-linux/1674/

@cjihrig
Copy link
Contributor

cjihrig commented Oct 21, 2019

Thank you @rvagg

@bnoordhuis
Copy link
Member Author

Thanks, Rod!

@joaocgreis
Copy link
Member

Added ARM64 to the Windows job. These are just 2 machines running from my office. They have been quite stable, but please mention me if there's any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants