Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read properties of undefined (reading 'at') #71

Closed
marco-ippolito opened this issue Jul 19, 2024 · 3 comments
Closed

Comments

@marco-ippolito
Copy link
Member

While preparing Node v20.16.0 release:

marcoippolito@marcos-MacBook-Pro node % N=20 sh -c 'branch-diff v$N.x-staging v22.4.0 --exclude-label=semver-major,dont-land-on-v$N.x,backport-requested-v$N.x,backport-blocked-v$N.x,backport-open-v$N.x,backported-to-v$N.x,baking-for-lts --filter-release --format=simple'
TypeError: Cannot read properties of undefined (reading 'at')
    at normalizeIfTrailingSlash (file:///Users/marcoippolito/.nvm/versions/node/v20.15.0/lib/node_modules/branch-diff/branch-diff.js:57:20)
    at isInList (file:///Users/marcoippolito/.nvm/versions/node/v20.15.0/lib/node_modules/branch-diff/branch-diff.js:64:5)
    at file:///Users/marcoippolito/.nvm/versions/node/v20.15.0/lib/node_modules/branch-diff/branch-diff.js:83:51
    at Array.filter (<anonymous>)
    at diffCollected (file:///Users/marcoippolito/.nvm/versions/node/v20.15.0/lib/node_modules/branch-diff/branch-diff.js:83:31)
    at branchDiff (file:///Users/marcoippolito/.nvm/versions/node/v20.15.0/lib/node_modules/branch-diff/branch-diff.js:47:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async main (file:///Users/marcoippolito/.nvm/versions/node/v20.15.0/lib/node_modules/branch-diff/branch-diff.js:173:14)
@rvagg
Copy link
Member

rvagg commented Jul 19, 2024

if (commit.prUrl.at(-1) === '/') {

#70 should have checked first whether prUrl even exists

@RafaelGSS pls take a look

@RafaelGSS
Copy link
Member

if (commit.prUrl.at(-1) === '/') {

#70 should have checked first whether prUrl even exists

@RafaelGSS pls take a look

I'm not with my computer right now. I should be able to fix it in a couple hours. Sorry about that

@marco-ippolito
Copy link
Member Author

fixed by #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants