-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
../src/node_jsvmapi.cc:192:3: error: ‘interface’ does not name a type #69
Comments
This line is: interface CallbackWrapper {
... Does the 'interface' keyword not exist in GCC? Is 'interface' an ISO standard keyword? I'm actually not sure. Looks like it might be an MSVC-specific #define. Maybe we should replace this with class or struct for compliance sake? |
I think so. It certainly doesn't build out of the box. |
@jasongin |
First, GCC doesn't seem to implement an interface keyword. Workaround here is to use struct instead of interface. This is nodejs#69 Second, GCC doesn't support the flavor of static_assert which takes a single parameter. Just added a second parameter message here.
There is another build issue on gcc, too, so I started a PR. #70 |
Yes, |
First, GCC doesn't seem to implement an interface keyword. Workaround here is to use struct instead of interface. This is #69 Second, GCC doesn't support the flavor of static_assert which takes a single parameter. Just added a second parameter message here.
Fixed by 5ae919a |
First, GCC doesn't seem to implement an interface keyword. Workaround here is to use struct instead of interface. This is #69 Second, GCC doesn't support the flavor of static_assert which takes a single parameter. Just added a second parameter message here.
The error handling modifications fail to build with GCC.
The text was updated successfully, but these errors were encountered: