Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash reported due to Node.js #34839 #411

Closed
mhdawson opened this issue Oct 21, 2020 · 3 comments
Closed

Crash reported due to Node.js #34839 #411

mhdawson opened this issue Oct 21, 2020 · 3 comments
Milestone

Comments

@mhdawson
Copy link
Member

nodejs/node#35620
Reported as being due to: nodejs/node@a6b6556

@mhdawson mhdawson added this to the Milestone 11 milestone Oct 21, 2020
@mhdawson
Copy link
Member Author

@gabrielschulhof in case you have a chance to take a look before the meeting on Friday.

@mhdawson
Copy link
Member Author

@gabrielschulhof my first thought is that even if there is no user provided finalizer, we've still set it up for the gc to call a Finalize() in js_native_api_v8.cc and therefore there is a race condition if we delete when reference->_finalize_callback is nullptr.

@mhdawson
Copy link
Member Author

Closing since we discussed, and the revert is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant